Skip to content

Add instrumentation to @netlify/blobs #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add instrumentation to @netlify/blobs #384

wants to merge 5 commits into from

Conversation

chee
Copy link
Contributor

@chee chee commented Jul 24, 2025

This uses the withActiveSpan export from #363 to add some instrumentation to blobs.

We're all very sad about reïndenting the entire file and replacing all the git blame with my face and name.

Untested, which is why this is a draft. But feel free to read and comment on the approach at your leisure.

Base automatically changed from otelmewhatyouwant to main July 24, 2025 13:18
@pieh pieh self-requested a review July 28, 2025 12:10
@pieh pieh marked this pull request as ready for review July 28, 2025 12:12
@pieh pieh requested a review from a team as a code owner July 28, 2025 12:12
@pieh pieh marked this pull request as draft July 28, 2025 12:13
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in progress, this "Request changes" is just to discard my previous approval which was accidental

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants